feat(raiko): retry task if previous running failed. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smtmfft <[email protected]>
Signed-off-by: smtmfft <[email protected]>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Signed-off-by: smtmfft <[email protected]>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Signed-off-by: smtmfft <[email protected]>
johntaiko
reviewed
Nov 15, 2024
| | TaskStatus::UnspecifiedFailureReason => { | ||
| manager | ||
| .update_task_progress(key, TaskStatus::Registered, None) | ||
| .await?; |
There was a problem hiding this comment.
If the update fails or task_channel is full, do we need to retry?
There was a problem hiding this comment.
both update fail & task_channel error will not be log into taskdb. For channel error, when client retries, if that time channel is free, it should be ok.
but update failure may not automatically recovered I think. for example if redis has no response, we must restart k8s node??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.